Pros
Every unit needs supply personnel, so you have the opportunity to be stationed anywhere in the world. Depending on your unit, this will help improve your inventory management skills as well as property accountability, and increasing you overall skill package at the same time. Primary functions are inventories, counting, and record keeping, so it's relatively manageable, but you'll get the opportunity to get outdoors when you're conducting/assisting in said inventories. You'll get to work closely with your Commander and First Sergeant, so that access is always a plus. This job will give you the valuable skills that you can use in the civilian sector. Just like every unit, every job requires logistics. Learn as much as you can so you can apply yourself once you are separated from the military. The medical, dental, and vision benefits are good. You get an increase in pay every 2 years you're in the military.
Cons
It's a thankless job and you'll most likely get treated like every other Soldier in your company. Too often you'll have to deal with fat, lazy, supply sergeants who are more interested in hoarding supplies and look for excuses to get out of details, or even PT. This job can be administratively heavy at times, which will cause you to take of general maintenance (weapons, uniforms, etc.) on your own time - unless you're one of the fat lazy ones, because then you'll skip out on actual work that needs to be done to take care of yourself. Supply personnel won't always get the personal and professional development they need/require as an NCO because it's a low density job, so all of that focus is shifted towards the other Soldiers in your unit. The only time leadership seems to care about any type of training are mandatory classes because the numbers have to be reported. No one thinks you do anything and they get upset if you don't have some random item that is not normally stocked.